Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform)!: system data contracts should not have an owner #1992

Merged
merged 12 commits into from
Jul 24, 2024

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Jul 23, 2024

Issue being fixed or feature implemented

Before this PR at genesis we created identities with keys that would become owners of system data contracts. Doing this brought with it the fact that the owner of the keys of these identities would be able to update the data contract.
This was not ideal, system contracts should only be updated by consensus.

What was done?

  • We set the owner of the system contracts to [0;32] (only zeros). Since this identity does not exist and can never exist this will have the consequence that the system contracts will have no owner.

How Has This Been Tested?

Updated existing tests

Breaking Changes

It is only slightly breaking, as the root state will change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov marked this pull request as ready for review July 24, 2024 01:48
@shumkov shumkov self-requested a review as a code owner July 24, 2024 01:48
@shumkov shumkov added this to the v1.0.0 milestone Jul 24, 2024
@QuantumExplorer QuantumExplorer changed the title feat: system data contracts should not have an owner feat(platform)!: system data contracts should not have an owner Jul 24, 2024
@shumkov shumkov merged commit 02942c2 into v1.0-dev Jul 24, 2024
98 checks passed
@shumkov shumkov deleted the feat/systemDataContractsHaveNoOwner branch July 24, 2024 09:53
@coderabbitai coderabbitai bot mentioned this pull request Nov 22, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants